Add a replace function that supports regex #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks for taking this on! |
|
Thanks for this, and sorry I've been so slow to review it! Can you add a test for the error case? I want to make sure the error message looks good. If the regex crate's error message doesn't show the original regex, we should include that as well. |
miles170
force-pushed
the
issue-1389-replace_regex
branch
from
5d56107
to
6fdee27
Compare
|
There is a typo in the README. (regec -> regex) |
|
Good catch! Fixing here: #1409. Tweaked the argument names and added an entry in the readme. I also removed the error prefix, I think the underlying error is probably descriptive enough. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
replace_regex(s, from, to)that supports replacing text using regular expressions.Closes #1389.