-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Snap #1231
Add support for Snap #1231
Conversation
@casey can I add a new release CI - |
@akshaybabloo Yup definitely. You could also add it to the existing release YAML file. Is there a good way to automatically update the version numbers? It would be nice if I didn't have to update the yaml files when cutting a new release. |
Working on it. I will add a shell script to update that. |
This can be left for another diff, just to keep things simple. Also, does the |
@casey I think its ready. I tried it locally and it runs fine. I have updated the description, you will hve to create the account and upload it 🤞🏾 |
Nice! Do you know if I can do this from a mac? I don't have an Ubuntu box handy. |
I think you can. https://snapcraft.io/docs/installing-snapcraft. My mac is way too old to handle this 😄 |
You will need Docker and Multipass though |
Can releasing on snap be done on github actions? I don't think I can commit to a manual release step. I make frequent releases, and I've found that I just do a bad job managing packages for OSs that I don't use. |
The But for now you will have to create a secret toke for this to work |
I just tried to publish, and it looks like |
Also, here's a snapcraft.yaml file with some more metadata: base: core20
confinement: classic
contact: casey@rodarmor.com
description: Just is a handy way to save and run project-specific commands.
grade: stable
icon: icon.png
issues: https://github.com/casey/just/issues
license: CC0-1.0
name: just
source-code: https://github.com/casey/just
summary: Just a command runner
version: '1.2.0'
website: https://just.systems
apps:
just:
command: bin/just
parts:
just:
source: https://github.com/casey/just
source-type: git
source-tag: '1.2.0'
source-depth: 1
plugin: rust |
I didn't actually. Must be someone else. I hope there is another name we can have it just to publish it? |
Updated |
I just submitted a request for the name, and it was approved. I think maybe they have some anti-squatting check for short names, or english words, or something. |
Can you enable pushes from reviewers for this PR? I'm updating the YAML file and building locally, and it would be convenient to be able to push the changes that I make to the PR branch. |
I think it's already enabled.
Nice! |
Are you sure? I tried to push, but it was rejected. You might have branch protection enabled on |
Something is completely hosed with git. I'm not sure if it's my local branch, something with how github is configured, or what. I was able to push the wrong commit to your branch (i force pushed master, which auto-closed the PR) but can't push the right branch. I'll push to a new branch and open a new PR. |
Okay. Yep Git does that time-to-time specially submodules |
This partially fixes #429 by adding support for Snap.
Now you will have to create a Ubuntu account and then install Snapcraft from your terminal
sudo snap install snapcraft --classic
=> this should also installmultipass
or else it will ask for you to installsnapcraft login
snapcraft export-login file.txt
- you might have to enter your username and password againSNAPCRAFT_LOGIN
as your key and the values from the file.You might probably want to try this on your local system. I think this should do it.