Suppress --fmt --check diff if --quiet is passed (#1457)

casey · Dec 21, 2022 · 9887582 · 9887582
1 parent fbe1c4c
commit 9887582
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/src/subcommand.rs b/src/subcommand.rs
@@ -374,21 +374,23 @@ impl Subcommand {
       return if formatted == src {
         Ok(())
       } else {
-        use similar::{ChangeTag, TextDiff};
-
-        let diff = TextDiff::configure()
-          .algorithm(similar::Algorithm::Patience)
-          .diff_lines(src, &formatted);
-
-        for op in diff.ops() {
-          for change in diff.iter_changes(op) {
-            let (symbol, color) = match change.tag() {
-              ChangeTag::Delete => ("-", config.color.stderr().diff_deleted()),
-              ChangeTag::Equal => (" ", config.color.stderr()),
-              ChangeTag::Insert => ("+", config.color.stderr().diff_added()),
-            };
-
-            eprint!("{}{symbol}{change}{}", color.prefix(), color.suffix());
+        if !config.verbosity.quiet() {
+          use similar::{ChangeTag, TextDiff};
+
+          let diff = TextDiff::configure()
+            .algorithm(similar::Algorithm::Patience)
+            .diff_lines(src, &formatted);
+
+          for op in diff.ops() {
+            for change in diff.iter_changes(op) {
+              let (symbol, color) = match change.tag() {
+                ChangeTag::Delete => ("-", config.color.stderr().diff_deleted()),
+                ChangeTag::Equal => (" ", config.color.stderr()),
+                ChangeTag::Insert => ("+", config.color.stderr().diff_added()),
+              };
+
+              eprint!("{}{symbol}{change}{}", color.prefix(), color.suffix());
+            }
           }
         }
 

diff --git a/tests/fmt.rs b/tests/fmt.rs
@@ -53,6 +53,14 @@ test! {
   status: EXIT_FAILURE,
 }
 
+test! {
+  name: check_found_diff_quiet,
+  justfile: "x:=``\n",
+  args: ("--unstable", "--fmt", "--check", "--quiet"),
+  stderr: "",
+  status: EXIT_FAILURE,
+}
+
 test! {
   name: check_diff_color,
   justfile: "x:=``\n",