Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rewards #334

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Feature/rewards #334

merged 3 commits into from
Oct 16, 2020

Conversation

rhyslbw
Copy link
Contributor

@rhyslbw rhyslbw commented Oct 8, 2020

Context

cardano-db-sync is now syncing the reward payouts into the db, so this PR extends the API model to include it.

Proposed Solution

  • New queries rewards and rewards_aggregate
  • Adds StakePool.rewards and StakePool.rewards_aggregate

Important Changes Introduced

  • Pinning the unreleased state of cardano-db-sync requires a db-rebuild
  • There is now an additional data volume to hold the ledger snapshots, which means the Docker service is now stateful.

@rhyslbw rhyslbw added the enhancement New feature or request label Oct 8, 2020
@rhyslbw rhyslbw self-assigned this Oct 8, 2020
Maps a new Docker volume in the compose file, as the service now
 maintains a rotation of ledger state snapshots.
While present in the API, it was not resolving to anything, so is not a breaking change
- top-level queries rewards and rewards_aggregate
- StakePool.rewards and StakePool.rewards_aggregate
@@ -44,10 +44,11 @@ services:
max-size: "400k"
max-file: "20"
cardano-db-sync-extended:
image: inputoutput/cardano-db-sync:${CARDANO_DB_SYNC_VERSION:-5.0.1}
image: rhyslbw/cardano-db-sync:${CARDANO_DB_SYNC_VERSION:-3e02b9370a122cef068e55ac2887b41acc7587ed}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to use this image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, commit builds are not not available for the inputoutput repository. Will be swapped out as part of the release pin

Copy link

@issoupadrink issoupadrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double check the image we're using in docker.yml and if that is correct then LGTM :)

@rhyslbw rhyslbw merged commit 4e84425 into master Oct 16, 2020
@rhyslbw rhyslbw deleted the feature/rewards branch October 16, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants