Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0028 | Adjust preamble and structure w.r.t CIP-0001 #676

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Dec 21, 2023

Fixes #675.

@kevinhammond as with #650 I've resolved the discrepancy in licensing agreements in favour of Apache (CC was indicated in the YAML header).

Editors: we need to keep an eye on how these Protocol Parameter CIPs are stacking on top of each other. The last solid resolution I remember (before @Ryun1 @Crypto2099 arrived) was that protocol parameter CIPs would describe differences with the previous ledger era, rather than a complete re-enumeration of parameters... but a lot of this material feels already stated in CIP-0009.

So although solving any issues of reference & redundancy is beyond the scope of the #389 "Remediation" (and therefore doesn't have to be attended to in this PR) I still think we should keep an eye on this issue (with help from @kevinhammond and @WhatisRT I hope) because otherwise this mangled history of protocol parameters is going to end up fossilised.

In this light I've removed a forward reference to CIP-0055 which was shoe-horned in here with #370 apparently after debate at at CIP meeting, since this would therefore be in direct conflict with the decision that parameter updates should be cumulative (and therefore containing only backward references):

### Change Log

See [CIP-0055: Protocol Parameters (Babbage Era)](../CIP-0055).

(updated proposal)

Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rphair
Copy link
Collaborator Author

rphair commented Jan 6, 2024

Merging this one with respect to the CIP-0001 "remediation" without an answer to my last question because, although consistency (redundancy vs. reference) between parameter update CIPs is important, that question isn't part of this remediation effort.

@rphair rphair merged commit f768442 into cardano-foundation:master Jan 6, 2024
@rphair rphair removed the Remediation label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIP-0028 | Adjust preamble and structure w.r.t CIP-0001
3 participants