Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0040? | Collateral output #216

Merged
merged 18 commits into from
Jul 2, 2022
Merged

CIP-0040? | Collateral output #216

merged 18 commits into from
Jul 2, 2022

Conversation

SebastienGllmt
Copy link
Contributor

@SebastienGllmt SebastienGllmt commented Feb 10, 2022

This PR describes adding a new output type to transactions called Collateral Outputs which removes the need for wallets to explicitly set collateral (which is bad UX) and improves safety of collateral at the same time

This PR is part of a series of different ways we can improve collateral handling in Cardano. You can find the three options below

Collateral Key
Collateral Output
Collateral Reward

@SebastienGllmt SebastienGllmt self-assigned this Feb 10, 2022
@@ -1,7 +1,7 @@
---
CIP: ?
Title: Explicit Collateral Output
Authors: Sebastien Guillemot <seba@dcspark.io>
Authors: Sebastien Guillemot <seba@dcspark.io>, Jared Corduan <jared.corduan@iohk.io>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Authors: Sebastien Guillemot <seba@dcspark.io>, Jared Corduan <jared.corduan@iohk.io>
Authors: Sebastien Guillemot <seba@dcspark.io>, Andre Knispel <andre.knispel@iohk.io>

@KtorZ KtorZ changed the title Collateral output CIP-40? | Collateral output Mar 17, 2022
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming that the following steps will be tackled before merging:

  • Change CIP number to 40
  • Move the file into the proper cip-0040 repository
  • Add it to the README table
  • Change status to proposed

@KtorZ KtorZ changed the title CIP-40? | Collateral output CIP-0040? | Collateral output May 11, 2022
@KtorZ
Copy link
Member

KtorZ commented Jun 7, 2022

(cc @rphair)

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KtorZ can other editors make changes like these (#216 (review)) to PR assets or would @SebastienGllmt be required to do it? If you've been doing these administrative changes before merge to other people's PR's, please let me know how 😎

@KtorZ
Copy link
Member

KtorZ commented Jun 7, 2022

@rphair it's sometimes possible depending on what the settings of the PR's authors are. Some authors disable editing of their PR, some don't. Most of the time though, we kindly ask authors to do so.

As for the how, through git usually, pushing directly on the branch (which is allowed by default for PR made to your repository, unless disabled).

@KtorZ
Copy link
Member

KtorZ commented Jun 30, 2022

@SebastienGllmt seems like this one has been forgotten a bit. If you have any time to tidy this up then please do, otherwise if you don't mind, I'll just do it :)

@rphair
Copy link
Collaborator

rphair commented Jul 2, 2022

OK @KtorZ @SebastienGllmt I wanted to be sure I could do this. Please feel free to double check & if anything wrong or missing let me know & I'll publish any fixes as a separate PR.

Cc @JaredCorduan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants