Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -p, —prototype command line option to select different repositories from the Carbon Five default #122

Conversation

drogar
Copy link
Contributor

@drogar drogar commented Nov 30, 2013

  • Enable the option that was there
  • In fetch_latest_tag:
    • Use parameter to method rather than instance variable for repo
    • Check that we get a “200” response - otherwise error out and let user know the response code
    • Check that we have at least one tag - otherwise error out and let user know about tags

If you wish, you can test this with my fork: drogar/raygun-rails4 - The latest version with kaminari is tagged.

 - Enable the option that was there
 - In fetch_latest_tag:
    - Use parameter to method rather than instance variable for repo
    - Check that we get a “200” response - otherwise error out and let user know the response code
    - Check that we have at least one tag - otherwise error out and let user know about tags
 - Describe usage with -p
 - Note that the repo must be tagged
 - Note that custom repos should not have binary files, due to use of sed

 - Output after generating from custom prototype reduced to basic congrats - can’t assume any of the next steps will be valid.
@christiannelson
Copy link
Contributor

Thanks @drogar! Merged.

@drogar
Copy link
Contributor Author

drogar commented Dec 2, 2013

My pleasure!

On Dec 2, 2013, at 11:12 AM, Christian Nelson notifications@github.com wrote:

Thanks @drogar! Merged.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants