fix(types): resolve commented issues

carbon-design-system · Sep 25, 2024 · 0702d1f · 0702d1f
1 parent d644788
commit 0702d1f
Show file tree

Hide file tree

Showing 13 changed files with 14 additions and 15 deletions.
diff --git a/packages/ibm-products/src/components/Checklist/Checklist.tsx b/packages/ibm-products/src/components/Checklist/Checklist.tsx
@@ -145,7 +145,6 @@ const defaults = {
   taskLists: [],
   theme: Themes.light,
   toggleLabel: 'Toggle',
-  toggleLabelAlign: 'top',
 };
 
 /**

diff --git a/packages/ibm-products/src/components/CreateTearsheet/CreateTearsheet.tsx b/packages/ibm-products/src/components/CreateTearsheet/CreateTearsheet.tsx
@@ -152,7 +152,7 @@ export interface CreateTearsheetProps extends PropsWithChildren {
   /**
    * The main title of the tearsheet, displayed in the header area.
    */
-  title?: string;
+  title?: ReactNode;
 
   /**
    * The position of the top of tearsheet in the viewport. The 'normal'
@@ -438,7 +438,7 @@ CreateTearsheet.propTypes = {
   /**
    * The main title of the tearsheet, displayed in the header area.
    */
-  title: PropTypes.string,
+  title: PropTypes.node,
 
   /**
    * The position of the top of tearsheet in the viewport. The 'normal'

diff --git a/packages/ibm-products/src/components/Datagrid/types/index.ts b/packages/ibm-products/src/components/Datagrid/types/index.ts
@@ -281,7 +281,7 @@ export interface DataGridState<T extends object = any>
   emptyStateAction: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
   emptyStateLink?: {

diff --git a/packages/ibm-products/src/components/EmptyStates/EmptyState.tsx b/packages/ibm-products/src/components/EmptyStates/EmptyState.tsx
@@ -44,7 +44,7 @@ interface EmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/packages/ibm-products/src/components/EmptyStates/ErrorEmptyState/ErrorEmptyState.tsx b/packages/ibm-products/src/components/EmptyStates/ErrorEmptyState/ErrorEmptyState.tsx
@@ -33,7 +33,7 @@ interface ErrorEmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/packages/ibm-products/src/components/EmptyStates/NoDataEmptyState/NoDataEmptyState.tsx b/packages/ibm-products/src/components/EmptyStates/NoDataEmptyState/NoDataEmptyState.tsx
@@ -32,7 +32,7 @@ interface NoDataEmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/packages/ibm-products/src/components/EmptyStates/NoTagsEmptyState/NoTagsEmptyState.tsx b/packages/ibm-products/src/components/EmptyStates/NoTagsEmptyState/NoTagsEmptyState.tsx
@@ -33,7 +33,7 @@ interface NoTagsEmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/packages/ibm-products/src/components/EmptyStates/NotFoundEmptyState/NotFoundEmptyState.tsx b/packages/ibm-products/src/components/EmptyStates/NotFoundEmptyState/NotFoundEmptyState.tsx
@@ -33,7 +33,7 @@ interface NotFoundEmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/...m-products/src/components/EmptyStates/NotificationsEmptyState/NotificationsEmptyState.tsx b/...m-products/src/components/EmptyStates/NotificationsEmptyState/NotificationsEmptyState.tsx
@@ -34,7 +34,7 @@ interface NotificationsEmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/...ibm-products/src/components/EmptyStates/UnauthorizedEmptyState/UnauthorizedEmptyState.tsx b/...ibm-products/src/components/EmptyStates/UnauthorizedEmptyState/UnauthorizedEmptyState.tsx
@@ -32,7 +32,7 @@ interface UnauthorizedEmptyStateProps {
   action?: {
     kind?: 'primary' | 'secondary' | 'tertiary';
     renderIcon?: CarbonIconType;
-    onClick?: ButtonProps<'button'>['onClick'];
+    onClick?: ButtonProps<React.ElementType>['onClick'];
     text?: string;
   };
 

diff --git a/packages/ibm-products/src/components/PageHeader/PageHeader.tsx b/packages/ibm-products/src/components/PageHeader/PageHeader.tsx
@@ -207,7 +207,7 @@ type PageActionProps =
        * - maxWidth: maximum number of pixels the content will grow to
        * Carbon Button API https://react.carbondesignsystem.com/?path=/docs/components-button--default#component-api
        */
-      pageActions: ButtonProps<'button'>[] | PageAction;
+      pageActions: ButtonProps<React.ElementType>[] | PageAction;
       /**
        * When there is insufficient space to display all of hte page actions inline a dropdown button menu is shown,
        * containing the page actions. This label is used as the display content of the dropdown button menu.
@@ -1174,7 +1174,7 @@ export let PageHeader = React.forwardRef(
                     `${blockClass}__button-set-menu-options`
                   )}
                   onWidthChange={handleWidthChange}
-                  buttons={pageActions as ButtonProps<'button'>[]}
+                  buttons={pageActions as ButtonProps<React.ElementType>[]}
                   buttonSetOverflowLabel={
                     pageActionsOverflowLabel as NonNullable<ReactNode>
                   }

diff --git a/packages/ibm-products/src/components/Tearsheet/TearsheetNarrow.tsx b/packages/ibm-products/src/components/Tearsheet/TearsheetNarrow.tsx
@@ -38,7 +38,7 @@ interface TearsheetNarrowBaseProps extends PropsWithChildren {
    *
    * See https://react.carbondesignsystem.com/?path=/docs/components-button--default#component-api
    */
-  actions?: ButtonProps<'button'>[];
+  actions?: ButtonProps<React.ElementType>[];
 
   /**
    * The aria-label for the tearsheet, which is optional.

diff --git a/packages/ibm-products/src/custom-typings/index.d.ts b/packages/ibm-products/src/custom-typings/index.d.ts
@@ -4,7 +4,7 @@
  * This source code is licensed under the Apache-2.0 license found in the
  * LICENSE file in the root directory of this source tree.
  */
-// @ts-nocheck
+
 declare module '@carbon/react' {
   export {
     Accordion,