Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: border issue for expandable interactive tile for feature flags #16580

Merged

Conversation

riddhybansal
Copy link
Contributor

Closes #15940

Since the entire tile is not clickable, the border should be around the button instead of being around the tile

Changelog

New

  • Added border to button for expandable interactive tile for feature flags

Removed

  • Removed border from the whole expandable interactive tile since its not clickable

Testing / Reviewing

Go to Feature Flags -> Tile -> Expandable With Interactive Tile

  • Tile should not have the border instead there should be border on the chevron button
  • These styles should not effect any other type of tile whether in feature flags or a normal component
  • Same styles should be present in the component using the Expandable With Interactive Tile (Ex: Expandable with Layer in feature flags)

Copy link

netlify bot commented May 27, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 29cd3a1
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66543a23fdc55d00085f7bc2
😎 Deploy Preview https://deploy-preview-16580--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 29cd3a1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66543a233a9f2c00089566c9
😎 Deploy Preview https://deploy-preview-16580--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisonjoseph alisonjoseph added this pull request to the merge queue May 29, 2024
Merged via the queue into carbon-design-system:main with commit d348aef May 29, 2024
21 checks passed
dkaushik95 pushed a commit to dkaushik95/carbon that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tile] Update the border on Expandable with interactive tiles
4 participants