Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom build backend to support build args #328

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

tobiasah
Copy link
Contributor

@tobiasah tobiasah commented Oct 2, 2023

This implements a custom build backend, inspired by the solution used by Pillow.

install-option is deprecated and was removed with pip 23.1. The comonly accepted solution seems to be to define a custom build backend for now
pypa/setuptools#2491 (comment)

This commit changes the usage from --install-option to --config-settings.

@tobiasah
Copy link
Contributor Author

tobiasah commented Oct 2, 2023

As mentioned here #323 the support for the latest pypi version should be addressed sooner than later.

@haata not sure if you already prepared something similar. This is just a proposal. I stayed with the arguments names already used ... I did not change anything else in the setup process (although it could need a polish) but I am happy to do this after this first adaption

capnp/lib/capnp_api.h Outdated Show resolved Hide resolved
This implements a custom build backend, inspired by the
[solution used by Pillow.](python-pillow/Pillow#7171)

install-option is deprecated and was removed with pip 23.1. The
comonly accepted solution seems to be to define a custom build
backend for now
pypa/setuptools#2491 (comment)

This commit changes the usage from `--install-option` to `--config-settings`.
@haata haata merged commit d48ffea into capnproto:master Oct 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants