Improve the manual "execute" customization

[upils]

Support args and env variables in the the "execute" customization to make it more useful.

See https://bugs.launchpad.net/ubuntu-image/+bug/2035216

[codecov]

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.76%. Comparing base (43771d1) to head (64e04cd).

Files	Patch %	Lines
internal/statemachine/helper.go	90.90%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (43771d1) and HEAD (64e04cd). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (43771d1)	HEAD (64e04cd)
unittests	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   93.99%   84.76%   -9.23%     
==========================================
  Files          18       18              
  Lines        3412     3466      +54     
==========================================
- Hits         3207     2938     -269     
- Misses        132      448     +316     
- Partials       73       80       +7     

Flag	Coverage Δ
unittests	84.76% <98.30%> (-9.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sil2100]

For now leaving a comment since I still need to think a bit more about this myself.

First of all: I see the addition of a test case for add-group here - is that related to the execute customization improvements? Feels a bit unfitting!

As for the change itself: I still need to think about this, but passing arguments as a list one-by-one feels a bit hm, artificial. It's certainly an option, but I'm thinking that maybe instead we should add a command: stanza or something where the user could simply execute the whole command to be run? Or maybe run:? While keeping path: there and slowly deprecating it (making it only run the command with no arguments). But I'm undecided myself yet. I'm thinking about this this way as imagine running a command that has 6 arguments to be passed - this would not really look nice or readable.

+1 on env though.

[upils]

First of all: I see the addition of a test case for add-group here - is that related to the execute customization improvements? Feels a bit unfitting!

I spotted the add-group customization was not tested and I added it. It was a bit careless and I will isolate it in a commit.

As for the change itself: I still need to think about this, but passing arguments as a list one-by-one feels a bit hm, artificial. It's certainly an option, but I'm thinking that maybe instead we should add a command: stanza or something where the user could simply execute the whole command to be run? Or maybe run:? While keeping path: there and slowly deprecating it (making it only run the command with no arguments). But I'm undecided myself yet. I'm thinking about this this way as imagine running a command that has 6 arguments to be passed - this would not really look nice or readable.

While doing it I was convinced that was a common way, but now that you mention it I checked several projects doing this kind of thing (ansible, terraform) and indeed the favored way is to gather everything under a single "command" field. Plus it looks indeed way easier to use.

As you mention we could add a "command" field (because it describes better what is expected) and we could redefine path as an alias to this field. So we will have a single underlying implementation and will be able let user migrate.

[sil2100]

Looks good to me now, thank you for the adjustments!