Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve attestation setup script #50

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

hector-cao
Copy link
Collaborator

  • Add reboot instruction in README
    after the setup script run for attestation, we need to reboot
    to have the right owner & group for /dev/sgx_provision (from udev rule)

  • Remove README section on use_secure_cert
    with the version 1.18-0ubuntu2 of libsgx-dcap-default-qpl
    the use_secure_cert is set to false by default

  • setup-attestation-host.sh : do not set user and group for /dev/sgx_provision
    the udev rules will take care of it

with the version 1.18-0ubuntu2 of libsgx-dcap-default-qpl
the use_secure_cert is set to false by default
after the setup script run for attestation, we need to reboot
to have the right owner & group for /dev/sgx_provision (from udev rule)
@hector-cao hector-cao requested a review from frenchwr April 3, 2024 21:37
@hector-cao hector-cao changed the title Dev attestation script Improve attestation setup script Apr 3, 2024
Copy link
Collaborator

@bktan8 bktan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@frenchwr frenchwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hector-cao hector-cao merged commit 92bf35c into main-next Apr 4, 2024
hector-cao added a commit that referenced this pull request Apr 4, 2024
* Add attestation setup script

* Check script is run with root privileges

* Add trust authority client in setup guest script

* Add build-essential to compile tdx-attest

* Add remote attestation setup and how to use instruction (#42)

Signed-off-by: Bun K Tan <bun.k.tan@intel.com>

* Validate and clean up attestation instructions (#48)

* Validate and clean up attestation instructions

* Use more explicit naming of attestation scripts

* Remove sudo from commands in guest

* Remove useless script setup-attestation.sh

* Use tdx-release PPA that contains released components (#49)

* Improve attestation setup script (#50)

* setup-attestation-host.sh : do not set user and group for /dev/sgx_provision

the udev rules will take care of it

* Remove README section on use_secure_cert

with the version 1.18-0ubuntu2 of libsgx-dcap-default-qpl
the use_secure_cert is set to false by default

* Add reboot instruction in README

after the setup script run for attestation, we need to reboot
to have the right owner & group for /dev/sgx_provision (from udev rule)

---------

Signed-off-by: Bun K Tan <bun.k.tan@intel.com>
Co-authored-by: Ubuntu <ubuntu@sysid-739457.maas>
Co-authored-by: Bun K Tan <bun.k.tan@intel.com>
Co-authored-by: Will French <will.french@canonical.com>
@hector-cao hector-cao deleted the dev-attestation-script branch April 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants