Improve the management of workdir cleanup for debugging purposes #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hector-cao
commented
Sep 13, 2024
hector-cao
commented
- In case of test failure, we would like that the workdir of qemu is not cleaned up so that we can do some debugging.
- Improve the management of environment variable TDXTEST_DEBUG that forbids the clean up of these workdirs at any case
hector-cao
force-pushed
the
noble-24.04-fix-cleanup
branch
from
979d42a
to
2bfc941
Compare
spmcmillan
reviewed
Sep 17, 2024
| """ | ||
| if report.failed: | ||
| # enable debug flag to avoid cleanup to happen | ||
| Qemu.QemuMachine.set_debug(True) |
There was a problem hiding this comment.
why do we want to avoid cleanup when a test fails? Don't we want the next text to start cleanly? I understand if we running individually and we can set "debug", but not generally
There was a problem hiding this comment.
each qemu has its own working folder (/tmp/tdxtest-xxxxx/) that is not shared with other tests qemu instances
hector-cao
force-pushed
the
noble-24.04-fix-cleanup
branch
4 times, most recently
from
dcc4cde
to
687c7d7
Compare
hector-cao
force-pushed
the
noble-24.04-fix-cleanup
branch
2 times, most recently
from
977defe
to
ec38679
Compare
- In case of test failure, we would like that the workdir of qemu is not cleaned up so that we can do some debugging. - Improve the management of environment variable TDXTEST_DEBUG that forbids the clean up of these workdirs at any case
hector-cao
force-pushed
the
noble-24.04-fix-cleanup
branch
from
ec38679
to
f4a1ab7
Compare
I decided to split this MR into 2, the current one is now only about workdir clean up and debug flag, the second one (#227) will be on the kvm unload issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.