Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): Add kernel crash dump checkbox to settings MAASENG-3758 #5538

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat(settings): Add kernel crash dump checkbox to settings MAASENG-3758 #5538

merged 1 commit into from
Sep 30, 2024
+130 −2

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Sep 30, 2024 •
edited by jira bot
Loading

Done

  • Added kernel crash dump checkbox to settings
  • Added feature flag for kernel crash dump
  • Added modified help icon with lighter color to match designs
  • Added tests for tooltips in form field
  • Specified exact values for submission (rather than just submitting values object

QA steps

  • Add VITE_APP_KERNEL_CRASH_DUMP_ENABLED = true to your .env.local
  • Go to /settings/configuration/kernel-parameters
  • Ensure the new checkbox is there and the designs match the spec
  • Hover over each of the ? icons and make sure the content matches the spec (linked above)

Fixes

Resolves MAASENG-3758

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@ndv99 ndv99 marked this pull request as ready for review September 30, 2024 13:10
@ndv99 ndv99 requested a review from tmerten September 30, 2024 13:10
tmerten
tmerten reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ndv99 ndv99 merged commit 6bd12d8 into canonical:main Sep 30, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmerten tmerten tmerten approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @tmerten