refactor: decrease complexity of ActionForm, NetworkTable, MachineForms #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
|
This looks really clean, I like it. What's the rationale for setting the complexity limit to 25? Is this a recommendation from TiCS, or just reflective of our codebase? |
Very good question, Nick. This is the lowest setting that works in our codebase without refactoring large number of files. I think we should aim at complexity level of 10. I'll add a JIRA issue to our technical debt objective for this. |
petermakowski
changed the title
petermakowski
force-pushed
the
test-add-complexity
branch
5 times, most recently
from
ca06aba
to
1ec703c
Compare
petermakowski
changed the title
- add eslint-plugin-complexity - add complexity lint rule with max of 25 Signed-off-by: Peter Makowski <me+git@petermakowski.io>
petermakowski
force-pushed
the
test-add-complexity
branch
from
1ec703c
to
343533c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
refactor: decrease complexity of ActionForm, NetworkTable, MachineForms
This is related to TICS checks and intends to improve the overall score for maas-ui.