-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: VLAN reserve range side panels #5389
Merged
petermakowski
merged 4 commits into
canonical:main
from
petermakowski:fix-vlan-reserve-range-side-panels
Apr 8, 2024
Merged
fix: VLAN reserve range side panels #5389
petermakowski
merged 4 commits into
canonical:main
from
petermakowski:fix-vlan-reserve-range-side-panels
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can delete a reserved range successfully, but the side panel does not close after this. |
Jay-Topher
reviewed
Apr 5, 2024
src/app/subnets/views/VLANDetails/VLANActionForms/VLANActionForms.tsx
Outdated
Show resolved
Hide resolved
- refactor: use explicit prop names for vland and subnet
petermakowski
force-pushed
the
fix-vlan-reserve-range-side-panels
branch
from
April 5, 2024 15:03
7798ed9
to
56c8ad1
Compare
Idk if this is just happening for me, but I'm still getting the issue with the "Delete reserved range" side panel not closing on success |
ndv99
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA steps
/MAAS/r/vlan/35
in demos)Screenshots
Notes