Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(machines): Broken routes for machine and controller logs lp2060133 #5387

Merged
merged 3 commits into from
Apr 4, 2024
Merged

fix(machines): Broken routes for machine and controller logs lp2060133 #5387

merged 3 commits into from
Apr 4, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Apr 4, 2024 •
edited
Loading

Done

  • Fixed broken routes for event logs and installation outputs in machine details

QA steps

Machines

  • Go to a machine's details page and click on logs
  • Ensure you can see the event logs
  • Click on installation output and ensure you can see it

Controllers

  • Go to a controller's details page and click on logs
  • Ensure you can see the event logs
  • Click on installation output and ensure you can see it

Fixes

Fixes lp2060133

Screenshots

Before

image

After

image

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@ndv99 ndv99 changed the title fix(machines): Broken routes for machine logs lp2060133 fix(machines): Broken routes for machine and controller logs lp2060133 Apr 4, 2024
petermakowski
petermakowski approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski
Copy link
Contributor

Unrelated, but we should fix that loading state.

Google Chrome screenshot 001783@2x

@petermakowski petermakowski merged commit 9d9edb4 into canonical:main Apr 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermakowski petermakowski petermakowski approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @petermakowski