Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static routes edit and delete lp#2060176 lp#2060177 MAASENG-2966 #5385

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix: static routes edit and delete lp#2060176 lp#2060177 MAASENG-2966 #5385

merged 2 commits into from
Apr 4, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Apr 4, 2024 •
edited
Loading

Done

  • fix: static routes edit and delete
    • add e2e test for static routes
    • add addSubnet cypress helper function

QA steps

  • Go to subnet details
  • Add a new static route
  • Click to edit the static route, change the IP, and submit
  • Verify the change has been saved and side panel closed
  • Click to delete the static route
  • Verify it's been deleted an side panel closed

Fixes

Fixes: lp#2060176 lp#2060177

Screenshots

Notes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petermakowski petermakowski changed the title fix: static routes edit and delete lp#2060176 lp#2060177 fix: static routes edit and delete lp#2060176 lp#2060177 MAASENG-2966 Apr 4, 2024
@petermakowski petermakowski force-pushed the fix-static-routes-lp#2060176-lp#2060177 branch from 6bd0b30 to 8d3536e Compare April 4, 2024 09:06
@petermakowski petermakowski marked this pull request as ready for review April 4, 2024 09:07
@petermakowski petermakowski force-pushed the fix-static-routes-lp#2060176-lp#2060177 branch from 8d3536e to c358340 Compare April 4, 2024 09:11
@petermakowski petermakowski force-pushed the fix-static-routes-lp#2060176-lp#2060177 branch from c358340 to 11c53f2 Compare April 4, 2024 09:12
ndv99
ndv99 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski enabled auto-merge (squash) April 4, 2024 09:44
@petermakowski petermakowski merged commit e4c49ba into canonical:main Apr 4, 2024
6 of 7 checks passed
@petermakowski petermakowski deleted the fix-static-routes-lp#2060176-lp#2060177 branch May 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99