Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mark UTC timestamps MAASENG-1315 #5384

Merged
merged 6 commits into from
Apr 5, 2024
Merged

feat: mark UTC timestamps MAASENG-1315 #5384

merged 6 commits into from
Apr 5, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Apr 3, 2024 •
edited
Loading

Done

  • feat: mark utc timestamps MAASENG-1315
    • add branded UtcTimestamp type
    • add date-fns-tz as a dependency
    • run tsc in cypress directory on lint

QA steps

  • Go to machine/controller details page and verify that all time strings are formatted correctly and have (UTC) appended at the end

Fixes

Fixes: MAASENG-1315

Screenshots

After

Google Chrome screenshot 001771@2x
Google Chrome screenshot 001769@2x
Google Chrome screenshot 001775@2x

Notes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petermakowski petermakowski force-pushed the feat-mark-utc-timestamps-MAASENG-1315 branch 8 times, most recently from 68528eb to b12c5cc Compare April 4, 2024 09:35
@petermakowski petermakowski marked this pull request as ready for review April 4, 2024 09:38
@Jay-Topher
Copy link
Contributor

Should the change also apply to this?
image

ndv99
ndv99 previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jay-Topher
Copy link
Contributor

The last update column on the tags page is also without UTC timestamps
image

@ndv99 ndv99 dismissed their stale review April 4, 2024 09:56

Failing CI and some QA stuff from jones

@petermakowski
Copy link
Contributor Author

Should the change also apply to this?
Good spot. Yes, will update.

@Jay-Topher
Copy link
Contributor

Just a few more /settings/scripts/commissioning and /network-discovery/

@petermakowski
Copy link
Contributor Author

Just a few more /settings/scripts/commissioning and /network-discovery/

Commissioning scripts are displayed in local time so no UTC is needed. I updated network discovery.

@petermakowski petermakowski force-pushed the feat-mark-utc-timestamps-MAASENG-1315 branch from d3fcf5a to c7527f7 Compare April 4, 2024 13:02
@petermakowski petermakowski force-pushed the feat-mark-utc-timestamps-MAASENG-1315 branch 5 times, most recently from 82bc1b6 to 5c3a773 Compare April 4, 2024 15:13
@petermakowski petermakowski requested a review from ndv99 April 5, 2024 12:26
@petermakowski petermakowski force-pushed the feat-mark-utc-timestamps-MAASENG-1315 branch from 5c3a773 to 65c8f5a Compare April 5, 2024 12:32
@ndv99
Copy link
Contributor

ndv99 commented Apr 5, 2024

Image list still needs to be updated
image

@ndv99
Copy link
Contributor

ndv99 commented Apr 5, 2024

Also, the "last seen" column on the network discovery list is needlessly being truncated here:
image

This can be fixed separately if you want, just thought I'd let you know

@petermakowski
Copy link
Contributor Author

Also, the "last seen" column on the network discovery list is needlessly being truncated here: ![image](https://private-
This can be fixed separately if you want, just thought I'd let you know

Thanks, created an issue for this: https://warthogs.atlassian.net/browse/MAASENG-2991

@petermakowski
Copy link
Contributor Author

petermakowski commented Apr 5, 2024 •
edited
Loading

Image list still needs to be updated

Good spot, updated sort key, missed this. Updated.

ndv99
ndv99 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I think this looks good now.

@petermakowski petermakowski merged commit 6590312 into canonical:main Apr 5, 2024
6 checks passed
@petermakowski petermakowski deleted the feat-mark-utc-timestamps-MAASENG-1315 branch May 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petermakowski @webteam-app @Jay-Topher @ndv99