chore: replace react-portal with react-use-portal #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Jay-Topher
force-pushed
the
MAASENG-1599-replace-react-portal-with-useportal
branch
from
6a733f9
to
1b41958
Compare
Jay-Topher
force-pushed
the
MAASENG-1599-replace-react-portal-with-useportal
branch
from
1b41958
to
f015b25
Compare
src/app/base/components/NodeConfigurationFields/NodeConfigurationFields.tsx
Outdated
Show resolved
Hide resolved
src/app/base/components/NodeConfigurationFields/NodeConfigurationFields.tsx
Show resolved
Hide resolved
src/app/base/components/NodeConfigurationFields/NodeConfigurationFields.tsx
Outdated
Show resolved
Hide resolved
Jay-Topher
force-pushed
the
MAASENG-1599-replace-react-portal-with-useportal
branch
2 times, most recently
from
19561c2
to
85e261d
Compare
Jay-Topher
force-pushed
the
MAASENG-1599-replace-react-portal-with-useportal
branch
from
bb09446
to
e40f32f
Compare
Co-authored-by: Peter Makowski <me+github@petermakowski.io>
Co-authored-by: Peter Makowski <me+github@petermakowski.io>
Co-authored-by: Peter Makowski <me+github@petermakowski.io>
Jay-Topher
force-pushed
the
MAASENG-1599-replace-react-portal-with-useportal
branch
from
e40f32f
to
c7a0663
Compare
petermakowski
approved these changes
Apr 9, 2024
petermakowski
force-pushed
the
MAASENG-1599-replace-react-portal-with-useportal
branch
from
54bbd11
to
637b7b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA steps
Fixes
Fixes: 1599
Screenshots
Notes