Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Google Analytics 4 MAASENG-2910 #5381

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 28, 2024

Done

  • chore: update to Google Analytics 4 MAASENG-2910
    • add @types/google.analytics
    • replace custom setup with react-ga4

QA steps

  • Open Google Tag Assisstant https://tagassistant.google.com/ and connect it to maas demo
  • Verify that google analytics events for page view are sent
  • Verify that machine listing bulk actions have associated google analytics events

Fixes

Fixes:

Screenshots

Notes

@webteam-app
Copy link

@petermakowski petermakowski force-pushed the chore-update-google-analytics-MAASENG-2910 branch 5 times, most recently from 6e4af31 to 015bf29 Compare March 28, 2024 12:05
@petermakowski petermakowski marked this pull request as ready for review March 28, 2024 12:08
@petermakowski petermakowski changed the title chore: update to Google Analytics 4 MAASENG-2910 WIP chore: update to Google Analytics 4 MAASENG-2910 Mar 28, 2024
@petermakowski petermakowski merged commit 7deb99c into canonical:main Apr 2, 2024
8 checks passed
@petermakowski petermakowski deleted the chore-update-google-analytics-MAASENG-2910 branch May 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants