Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dead code #5380

Merged
merged 1 commit into from
Mar 28, 2024
Merged

refactor: remove dead code #5380

merged 1 commit into from
Mar 28, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 27, 2024 •
edited
Loading

Done

  • refactor: remove dead code

This removes some of the dead code as identified by npx unimported

QA

  • Verify that machine list, machine details, controller -> networking tab load without errors

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petermakowski petermakowski marked this pull request as ready for review March 27, 2024 15:20
ndv99
ndv99 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit 3e724e1 into canonical:main Mar 28, 2024
7 checks passed
@petermakowski petermakowski deleted the refactor-remove-dead-code branch May 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99