Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change source side panel lp#2058340 #5377

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 26, 2024

Done

  • fix: change source side panel lp#2058340
    • wrap application layout overrides in l-application for higher specificity

QA steps

  • Go to images
  • Press Change source
  • Paste in http://images.maas.io/ephemeral-v3/candidate as URL
  • Press connect
  • Verify that the next step is displayed using a large side panel size

Fixes

Fixes:

Screenshots

Before

Google Chrome screenshot 001739@2x

After

Google Chrome screenshot 001737@2x
Google Chrome screenshot 001735@2x

Notes

@webteam-app
Copy link

- wrap application layout overrides in l-application for higher specificity
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit 9fc538f into canonical:main Mar 27, 2024
7 checks passed
@petermakowski petermakowski deleted the fix-change-source-side-panel-lp#2058340 branch May 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants