Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: soft power off lp#2058662 #5371

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: soft power off lp#2058662 #5371

merged 1 commit into from
Mar 26, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 25, 2024 •
edited
Loading

Done

  • fix: soft power off

QA steps

  • Attept to soft power off a machine
  • Verify the action has been successful and a correct payload sent via websockets
{
  method: "machine.action"
  params: {action: "off", extra: {stop_mode: "soft"}, filter: {id: ["[id]"], ... },}
}

Fixes

Fixes: https://warthogs.atlassian.net/browse/MAASENG-2913
lp#2058662

Screenshots

Notes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petermakowski petermakowski marked this pull request as ready for review March 25, 2024 16:11
ndv99
ndv99 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit a370a7d into canonical:main Mar 26, 2024
7 checks passed
@petermakowski petermakowski deleted the fix-soft-power-off-MAASENG-2913-lp#2058662 branch May 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petermakowski @webteam-app @ndv99 @Jay-Topher