fix: enable name column on partitions table on side panel close #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://maas-ui-5344.demos.haus |
ndv99
requested changes
Mar 13, 2024
| @@ -286,8 +287,9 @@ const AvailableStorageTable = ({ | |||
| const dispatch = useDispatch(); | |||
| const [expanded, setExpanded] = useState<Expanded | null>(null); | |||
| const [selected, setSelected] = useState<(Disk | Partition)[]>([]); | |||
| const [bulkAction, setBulkAction] = useState<BulkAction | null>(null); | |||
| const [, setBulkAction] = useState<BulkAction | null>(null); | |||
There was a problem hiding this comment.
If bulkAction was only used for deciding whether or not actions should be disabled, and that value is now unneeded, we should also be able to remove all calls for setBulkAction without any side effects, and then we can remove this state entirely.
Jay-Topher
force-pushed
the
MAASENG-2799-enable-name=column-on-close-sidepanel
branch
from
7b3efdc
to
e58a1c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA steps
/machine/:id/storagefor a ready machineFixes
Fixes: Dev: Enable name column after side panel is closed
Screenshots
Notes