Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prefs): Adding SSL key no longer shows "Removed" message MAASENG-2813 #5340

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix(prefs): Adding SSL key no longer shows "Removed" message MAASENG-2813 #5340

merged 1 commit into from
Mar 12, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Mar 12, 2024 •
edited by Jay-Topher
Loading

Done

  • Added condition for displaying message to ensure that it is only displayed when deleting

QA steps

  • Go to /account/prefs/ssl-keys
  • Add an SSL key (you can make one here)
  • Ensure only the "added" notification is displayed
  • Delete the SSL key
  • Ensure only one "removed" notification is displayed

Fixes

Fixes MAASENG-2813

Screenshots

Before

image

After

image

@webteam-app
Copy link

Demo starting at https://maas-ui-5340.demos.haus

Jay-Topher
Jay-Topher approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ndv99 ndv99 merged commit 402bb24 into canonical:main Mar 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

@petermakowski petermakowski Awaiting requested review from petermakowski

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @Jay-Topher