Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(users): Adding/editing user no longer shows "Deleted" message MAASENG-2797 #5339

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Mar 12, 2024

Done

  • Removed useAddMessage call in user list
  • Changed deletion message in UserDeleteForm

QA steps

  • Go to /settings/users
  • Add a user
  • Ensure only the "created" notification is displayed
  • Edit the user
  • Ensure only the "edited" notification is displayed
  • Delete the user
  • Ensure only one "deleted" notification is displayed

Fixes

Fixes MAASENG-2797

Screenshots

Before

image

After

image

@webteam-app
Copy link

Demo starting at https://maas-ui-5339.demos.haus

Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndv99 ndv99 merged commit d9346e6 into canonical:main Mar 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants