Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move machine details forms to side panel #5336

Conversation

Jay-Topher
Copy link
Contributor

Done

  • Mark connected
  • Edit Physical
  • Add VLAN
  • Remove Physical
    Have all been moved to side panels

QA steps

  • Visit machine details page
  • Navigate to the network tab
  • Ensure all the action forms on the table open up in a side panel
  • Ensure the forms submit successfully

Fixes

Fixes: Dev: Display Edit physical, Remove bridge forms in a side panel

Screenshots

Before

image
image
image

After

image
image
image

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5336.demos.haus

@ndv99
Copy link
Contributor

ndv99 commented Mar 11, 2024

Just my take, but I really think the "Edit physical" form should use the "large" side panel size, if we want to display that table at the top.

@Jay-Topher
Copy link
Contributor Author

Just my take, but I really think the "Edit physical" form should use the "large" side panel size, if we want to display that table at the top.

Sounds fair, but do we really need a table for this use case?

@ndv99
Copy link
Contributor

ndv99 commented Mar 11, 2024

Just my take, but I really think the "Edit physical" form should use the "large" side panel size, if we want to display that table at the top.

Sounds fair, but do we really need a table for this use case?

That's also a fair point. I'll leave it to you then - either make the side panel larger, or keep the current size and remove that table row from the form

- Mark connected
- Edit Physical
- Add VLAN
- Remove Physical
@Jay-Topher Jay-Topher force-pushed the MAASENG-2796-move-machine-details-forms-to-sidepanel branch from 074874f to 429d10f Compare March 11, 2024 15:22
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jay-Topher Jay-Topher merged commit 7d0fcb5 into canonical:main Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants