Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change storage layout sidepanel MAASENG-2798 #5335

Merged

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 11, 2024

Done

  • fix: change storage layout sidepanel MAASENG-2798
    • close side panel on success
    • set correct panel title
    • refactor: rename constants to reflect node action

QA steps

  • Go to machine details, storage tab
  • Open change layout form
  • Verify side panel has a correct title
  • Verify it gets closed when action has been successful

Fixes

Fixes: MAASENG-2798

Screenshots

Before

Google Chrome screenshot 001613@2x

After

Google Chrome screenshot 001611@2x

Notes

- close side panel on success
- set correct panel title
- refactor: rename constants to reflect node action
@webteam-app
Copy link

Demo starting at https://maas-ui-5335.demos.haus

@Jay-Topher
Copy link
Contributor

Demos aren't working, I'll QA locally

@petermakowski petermakowski merged commit cb8f225 into canonical:main Mar 11, 2024
12 checks passed
@petermakowski petermakowski deleted the fix-storage-layout-sidepanel branch May 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants