Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prefs): Adding/editing API key no longer shows "Deleted" message MAASENG-2812 #5334

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(prefs): Adding/editing API key no longer shows "Deleted" message MAASENG-2812 #5334

merged 1 commit into from
Mar 11, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Mar 11, 2024 •
edited by jira bot
Loading

Done

  • Removed line showing "Deleted" notification every time an API key update was saved
  • Added line to API key delete form to show "Deleted" notification on save

QA steps

  • Go to r/account/prefs/api-keysr/account/prefs/api-keys
  • Generate an API key
  • Ensure only one notification is displayed: "API key successfully generated"
  • Edit that API key
  • Ensure only one notification is displayed: "API key edited successfully"
  • Delete the API key
  • Ensure only one notification is displayed: "API key deleted successfully"

Fixes

Fixes MAASENG-2812

Screenshots

Before

image

After

image

@webteam-app
Copy link

Demo starting at https://maas-ui-5334.demos.haus

@ndv99 ndv99 enabled auto-merge (squash) March 11, 2024 09:37
petermakowski
petermakowski approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, still need to QA (waiting for the demo) ⚡

@ndv99 ndv99 merged commit 38fc68e into canonical:main Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermakowski petermakowski petermakowski approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @petermakowski