Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dotrun): remove start_django_db #5331

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 5, 2024

Done

  • build(dotrun): remove start_django_db
    • this is no longer relevant and code unused (no python files in the repository)

QA steps

  • Run dotrun and make sure the front-end server starts successfully

Fixes

Fixes:

Screenshots

Notes

https://code.launchpad.net/~javier-fs/maas/+git/maas/+merge/461382

@webteam-app
Copy link

Demo starting at https://maas-ui-5331.demos.haus

@ndv99
Copy link
Contributor

ndv99 commented Mar 5, 2024

Not sure if it's just me, but running dotrun results in this error:

error vite@5.1.4: The engine "node" is incompatible with this module. Expected version "^18.0.0 || >=20.0.0". Got "16.19.1"
error Found incompatible module.

@Jay-Topher
Copy link
Contributor

Yeah, I got the same error, on my machine

@Jay-Topher
Copy link
Contributor

Not sure if it's just me, but running dotrun results in this error:

error vite@5.1.4: The engine "node" is incompatible with this module. Expected version "^18.0.0 || >=20.0.0". Got "16.19.1"
error Found incompatible module.

I don't think it has anything to do with ths change though.

@petermakowski
Copy link
Contributor Author

@ndv99 @Jay-Topher You need to make sure you have the latest version of the dotrun image, it's been fixed: canonical/dotrun-image@63768e5

docker pull canonicalwebteam/dotrun-image:latest

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the docker image like you said, and it ran fine 😅 LGTM

@petermakowski petermakowski merged commit 1fd5c12 into canonical:main Mar 5, 2024
9 checks passed
@petermakowski petermakowski deleted the build-dotrun-remove-start_django_db branch March 5, 2024 14:33
@petermakowski petermakowski restored the build-dotrun-remove-start_django_db branch May 9, 2024 10:21
@petermakowski petermakowski deleted the build-dotrun-remove-start_django_db branch May 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants