fix: composing machine does not update list lp#1842524 #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://maas-ui-5326.demos.haus |
petermakowski
changed the title
🙈 |
petermakowski
force-pushed
the
fix-composing-machine-list-update-lp#1842524
branch
from
c48002f
to
21771b4
Compare
|
Having difficulties QAing this (no cores available), @ndv99 could you have a look? |
|
Currently setting up a local env to QA this in, hopefully shouldn't be too long before I can +1 this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
This ensures we refetch machine list on compose success via
dispatch(machineActions.invalidateQueries());and update the list immediately. It also addsstale: falseto success actions to ensure consistent behaviour.QA steps
Fixes
Fixes: lp#1842524
Screenshots
Notes