Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport #5151 lxd certificate code block #5321

Conversation

petermakowski
Copy link
Contributor

Done

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Steps for QA.

Fixes

Fixes: # .

Launchpad issue

Related Launchpad maas issue in the form lp#number.

Backports

In general, please propose fixes against main rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.

Only bug and security fixes should be backported, new features should only land in main.

Screenshots

It could be helpful to provide some screenshots to aid in QAing the change.

@webteam-app
Copy link

Demo starting at https://maas-ui-5321.demos.haus

@petermakowski
Copy link
Contributor Author

Failing dotrun can be ignored as we removed this step from the CI for PRs on main. We should followup and update that for the 3.4 branch as well.

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski enabled auto-merge (squash) February 27, 2024 16:03
@petermakowski petermakowski merged commit 03a331c into canonical:3.4 Feb 27, 2024
2 of 3 checks passed
@petermakowski petermakowski deleted the fix-backport-#5151-MAASENG-2145-lxd-certificate-code-block branch February 27, 2024 16:03
@petermakowski petermakowski restored the fix-backport-#5151-MAASENG-2145-lxd-certificate-code-block branch May 9, 2024 10:21
@petermakowski petermakowski deleted the fix-backport-#5151-MAASENG-2145-lxd-certificate-code-block branch May 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants