Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings top padding #5319

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Feb 22, 2024

Done

  • fix: settings preferences pages top padding
    • refactor: remove redundant sidebar, isNotificationListHidden props
    • refactor NotificationList
    • add count selector to messages

QA steps

  • Go to settings page with no notifications active and verify that the page title is in line with secondary navigation title

Fixes

Fixes:

Screenshots

Before

Google Chrome screenshot 001569@2x

After

Google Chrome screenshot 001571@2x

Google Chrome screenshot 001567@2x

Google Chrome screenshot 001565@2x

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5319.demos.haus

- refactor: remove redundant sidebar, isNotificationListHidden props
- refactor NotificationList
- add count selector to messages
@petermakowski petermakowski force-pushed the fix-settings-top-padding-MAASENG-2757 branch from c5269c7 to daf2640 Compare February 22, 2024 11:23
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petermakowski petermakowski enabled auto-merge (squash) February 22, 2024 11:30
@petermakowski petermakowski merged commit 352f85c into canonical:main Feb 22, 2024
7 checks passed
@petermakowski petermakowski deleted the fix-settings-top-padding-MAASENG-2757 branch May 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants