Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update machine deploy form UI behavior #5318

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: update machine deploy form UI behavior #5318

merged 1 commit into from
Feb 22, 2024

Conversation

Jay-Topher
Copy link
Contributor

@Jay-Topher Jay-Topher commented Feb 22, 2024 •
edited by jira bot
Loading

Done

  • Made sidepanel header sticky
  • Removed unwanted hr and processing text from deploy form

QA steps

  • Goto /machines
  • Select a machine > Actions > Deploy
  • Ensure the form displays correctly and header is sticky when you scroll
  • Click on 'Deploy' and ensure that the button does not jump

Fixes

Fixes: MAASENG-2756

Screenshots

Before

Screencast.from.02-22-2024.10.14.12.AM.webm

After

Screencast.from.02-22-2024.10.16.54.AM.webm

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5318.demos.haus

@Jay-Topher Jay-Topher changed the title fix: update machine deploy form UI fix: update machine deploy form UI behavior Feb 22, 2024
petermakowski
petermakowski reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction! Appreciate before and after videos, very helpful. Please take a look at the comment below.

src/app/base/components/SectionHeader/_index.scss Outdated Show resolved Hide resolved
@Jay-Topher Jay-Topher force-pushed the fix-machine-deploy-form-MAASENG-2756 branch from 441fd8f to 97eb11c Compare February 22, 2024 11:05
@petermakowski petermakowski merged commit c8055ee into canonical:main Feb 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgtlntv dgtlntv dgtlntv left review comments

@petermakowski petermakowski petermakowski approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jay-Topher @webteam-app @petermakowski @dgtlntv