Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tags header update action #5312

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: tags header update action #5312

merged 1 commit into from
Feb 7, 2024

Conversation

petermakowski
Copy link
Contributor

Done

  • fix: tags header update action button
    • remove redundant tag view state logic

QA steps

  • Go to tags page
  • Click on a tag link
  • Select Update
  • Verify a side panel has been opened and you can save your changes
  • Verify that the side panel has been closed upon completion

Fixes

Fixes:

Screenshots

Before

Google Chrome screenshot 001518@2x

After

Google Chrome screenshot 001516@2x

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5312.demos.haus

@petermakowski petermakowski force-pushed the fix-tags-header branch 2 times, most recently from 1400369 to 834f2f4 Compare February 6, 2024 16:22
@petermakowski petermakowski marked this pull request as ready for review February 6, 2024 16:23
@petermakowski
fix: tags header update link
35cec96 
- remove redundant tag view state logic
ndv99
ndv99 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit 5fbd6be into canonical:main Feb 7, 2024
6 checks passed
@petermakowski petermakowski deleted the fix-tags-header branch May 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99