Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run cypress using dev server #5297

Merged
merged 4 commits into from
Jan 23, 2024
Merged

ci: run cypress using dev server #5297

merged 4 commits into from
Jan 23, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jan 22, 2024

Done

Integration of Cypress e2e Tests Pre-Merge against latest commit

This enables the execution of Cypress end-to-end tests prior to merging changes. It ensures tests run against the latest commit in a pull request, rather than latest snap build.

Kudos to @ndv99 for his work on integrating vite with maas-ui, which significantly increased performance and made the use of a development server for testing feasible.

  • ci: run cypress using dev server

Screenshots

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5297.demos.haus

@petermakowski petermakowski force-pushed the ci-run-cypress-on-dev branch 2 times, most recently from ff9cdca to ab6ee0b Compare January 22, 2024 12:09
@petermakowski petermakowski marked this pull request as ready for review January 22, 2024 12:10
@petermakowski petermakowski force-pushed the ci-run-cypress-on-dev branch 2 times, most recently from ab6ee0b to 776f9ff Compare January 22, 2024 12:12
@petermakowski petermakowski force-pushed the ci-run-cypress-on-dev branch 3 times, most recently from 6b48fe6 to 7e376e7 Compare January 22, 2024 13:21
@petermakowski petermakowski changed the title ci: run cypress using dev server WIP ci: run cypress using dev server Jan 22, 2024
@petermakowski
Copy link
Contributor Author

Cypress test failure above is expected, it reflects what happens on main atm.

Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice cleanups as well.

Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hu? I am 80% sure I toggled that radio to approved on the last comment already ;)

@petermakowski petermakowski merged commit f049c15 into main Jan 23, 2024
10 of 11 checks passed
@petermakowski petermakowski deleted the ci-run-cypress-on-dev branch April 26, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants