Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run sitespeed on push #5247

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jan 2, 2024

Done

This sets sitespeed.io action to be run on push to main/3.x branch instead of pull request close. This is consistent with how cypress tests are run.

  • ci: run sitespeed on push

QA steps

Fixes

Fixes: #5235

Screenshots

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5247.demos.haus

@petermakowski petermakowski force-pushed the update-sitespeed-action-permissions branch 2 times, most recently from e4788b5 to 8626d62 Compare January 3, 2024 08:18
@petermakowski petermakowski changed the title ci: update sitespeed action permissions ci: run sitespeed on push Jan 3, 2024
@petermakowski petermakowski marked this pull request as ready for review January 3, 2024 08:21
@Jay-Topher
Copy link
Contributor

The sitespeed job linked in the QA failed from 17 hrs ago, is there a more recent run?

@petermakowski
Copy link
Contributor Author

The sitespeed job linked in the QA failed from 17 hrs ago, is there a more recent run?

No, sorry, forgot to update QA steps. This will only run on main. No QA necessary.

@petermakowski petermakowski force-pushed the update-sitespeed-action-permissions branch from 8626d62 to 718601e Compare January 3, 2024 08:39
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petermakowski petermakowski merged commit e89172c into canonical:main Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sitespeed.io run failed
3 participants