Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controllers): use MainToolbar in ControllerListHeader MAASENG-2513 #5238

Merged
merged 2 commits into from
Dec 12, 2023
Merged

feat(controllers): use MainToolbar in ControllerListHeader MAASENG-2513 #5238

merged 2 commits into from
Dec 12, 2023

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Dec 11, 2023 •
edited by petermakowski
Loading

Done

  • Upgraded @canonical/maas-react-components to v1.12.0
  • Replaced SectionHeader with MainToolbar in ControllerListHeader

QA steps

  • Go to /controllers
  • Ensure the header renders correctly

Fixes

Fixes MAASENG-2513

@webteam-app
Copy link

Demo starting at https://maas-ui-5238.demos.haus

@Jay-Topher
Copy link
Contributor

Correct me if I'm wrong, from the designs, shouldn't it be this way?
image

@Jay-Topher
Copy link
Contributor

Correct me if I'm wrong, from the designs, shouldn't it be this way? image

I think I may be getting ahead of myself, nevermind

@petermakowski petermakowski mentioned this pull request Dec 12, 2023
Merged
1 task
petermakowski
petermakowski approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski
Copy link
Contributor

changed commit name to feat(controllers). This change affects functionality.

@petermakowski petermakowski merged commit 7667c2d into canonical:main Dec 12, 2023
6 of 7 checks passed
@petermakowski petermakowski changed the title chore(controllers): use MainToolbar in ControllerListHeader MAASENG-2513 feat(controllers): use MainToolbar in ControllerListHeader MAASENG-2513 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermakowski petermakowski petermakowski approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndv99 @webteam-app @Jay-Topher @petermakowski