Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use MainToolbar across all main pages in maas-ui MAASENG-2440 WIP #5237

Closed
wants to merge 2 commits into from

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Dec 11, 2023

Done

  • Upgrade @canonical/maas-react-components to v1.12.0
  • Use MainToolbar in:
  • Controller List
  • Controller Details
  • Device List
  • Device Details
  • DNS list
  • Domain Details
  • Image list
  • LXD list
  • LXD details
  • Virsh list
  • Virsh details
  • Machine list
  • Machine details
  • Network discovery list
  • Pools list
  • API key list
  • SSH key list
  • SSL key list
  • Subnets list

QA steps

  • Go to each page listed above
  • Ensure page header renders correctly

Fixes

Fixes MAASENG-2440

Screenshots

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5237.demos.haus

@ndv99
Copy link
Contributor Author

ndv99 commented Dec 11, 2023

Actually, I'm gonna do this in smaller PRs.

@ndv99 ndv99 closed this Dec 11, 2023
@ndv99 ndv99 deleted the MAASENG-2440-use-main-toolbar branch December 11, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants