fix(navigation): Prevent secondary navigation from displaying without auth MAASENG-1986 #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… auth MAASENG-1986
|
Demo starting at https://maas-ui-5067.demos.haus |
petermakowski
approved these changes
Jul 20, 2023
Comment on lines
+42
to
+75
| it("shows the secondary navigation for settings", () => { | ||
| state.status.authenticated = true; | ||
| state.status.connected = true; | ||
| renderWithBrowserRouter( | ||
| <PageContent | ||
| header="Settings" | ||
| sidePanelContent={null} | ||
| sidePanelTitle={null} | ||
| > | ||
| content | ||
| </PageContent>, | ||
| { route: "/settings/configuration/general", state } | ||
| ); | ||
|
|
||
| expect(screen.getByRole("navigation")).toBeInTheDocument(); | ||
|
|
||
| settingsNavItems.forEach((item) => { | ||
| expect(screen.getByText(item.label)).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
||
| it("shows the secondary navigation for preferences", () => { | ||
| state.status.authenticated = true; | ||
| state.status.connected = true; | ||
| renderWithBrowserRouter( | ||
| <PageContent | ||
| header="Preferences" | ||
| sidePanelContent={null} | ||
| sidePanelTitle={null} | ||
| > | ||
| content | ||
| </PageContent>, | ||
| { route: "/account/prefs/details", state } | ||
| ); |
There was a problem hiding this comment.
This is fine as is, but generally I'd be for merging these 2 tests into 1.
https://kentcdodds.com/blog/write-fewer-longer-tests
petermakowski
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: Code needed
Review: QA needed
labels
Co-authored-by: Peter Makowski <peter@makowski.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
MAAS deployment
To run this branch you will need access to one of the following MAAS deployments:
Running the branch
You can run this branch by:
QA steps
Fixes
Fixes MAASENG-1986