Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update document semantics MAASENG-1263 #5065

Merged
merged 1 commit into from
Jul 19, 2023
Merged

update document semantics MAASENG-1263 #5065

merged 1 commit into from
Jul 19, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jul 18, 2023 •
edited
Loading

Done

  • update document semantics MAASENG-1263
    • add labels to header elements

QA

QA steps

  • Go to dashboard
  • verify it's displayed correctly
  • In a new MAAS instance (alternatively you can remove redirects from components in order to force /intro routes to persist) that doesn't have user intro completed:
    • Go through all user setup steps
    • Verify each step is displayed correctly

Fixes

Fixes: https://warthogs.atlassian.net/browse/MAASENG-1263

Screenshots

user intro notifications along with regular notifications

image

user intro loading state

before

image

after

image

@webteam-app
Copy link

Demo starting at https://maas-ui-5065.demos.haus

@petermakowski petermakowski marked this pull request as ready for review July 18, 2023 11:47
ndv99
ndv99 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM

@petermakowski petermakowski merged commit baa0060 into canonical:main Jul 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99