Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DHCP snippets machine pagination #5057

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: DHCP snippets machine pagination #5057

merged 1 commit into from
Jul 17, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jul 14, 2023 •
edited
Loading

Done

  • fix: DHCP snippets machine pagination

QA steps

  • Go to DHCP snippets
  • click "add snippet"
  • select type machine
  • ensure that pagination buttons work correctly and requested page is displayed

@webteam-app
Copy link

Demo starting at https://maas-ui-5057.demos.haus

@petermakowski petermakowski force-pushed the fix-dhcp-snippets-machine-search branch from ee6a4e6 to b87c911 Compare July 17, 2023 08:37
@petermakowski petermakowski marked this pull request as ready for review July 17, 2023 08:38
Jay-Topher
Jay-Topher approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@petermakowski petermakowski merged commit 2a747ac into canonical:main Jul 17, 2023
4 checks passed
@petermakowski petermakowski deleted the fix-dhcp-snippets-machine-search branch May 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @Jay-Topher