Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: machine list select all MAASENG-1688 #5052

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat: machine list select all MAASENG-1688 #5052

merged 1 commit into from
Jul 14, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jul 13, 2023 •
edited
Loading

Done

  • feat: machine list select all MAASENG-1688
    • fix: pass filter to useMachineSelectedCount for a correct machine count
    • make filter required

QA

QA steps

  • Go to machine list
  • Select group by status
  • Add filter by owner
  • Select a group of machines
  • Ensure the number of machines is correct
  • Click "Categorise" -> Tag
  • add a new tag
  • verify the action has been performed only on specified selected and filtered machines

Fixes

https://warthogs.atlassian.net/browse/MAASENG-1688

Screenshots

Google Chrome screenshot 000395@2x

@webteam-app
Copy link

Demo starting at https://maas-ui-5052.demos.haus

@petermakowski petermakowski force-pushed the feat-machine-list-select-all-MAASENG-1688 branch 3 times, most recently from f1f6e86 to 0964ab7 Compare July 13, 2023 11:42
@petermakowski petermakowski force-pushed the feat-machine-list-select-all-MAASENG-1688 branch from 0964ab7 to 590f1bb Compare July 13, 2023 12:02
@petermakowski petermakowski marked this pull request as ready for review July 13, 2023 12:02
Jay-Topher
Jay-Topher approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected

@petermakowski petermakowski merged commit b8f6509 into canonical:main Jul 14, 2023
4 checks passed
@petermakowski petermakowski deleted the feat-machine-list-select-all-MAASENG-1688 branch May 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @Jay-Topher