Skip to content

Commit

Permalink
fix: merge conflicts from main
Browse files Browse the repository at this point in the history
  • Loading branch information
Jay-Topher committed Jan 15, 2024
1 parent dee6a8e commit c7c81de
Show file tree
Hide file tree
Showing 93 changed files with 630 additions and 634 deletions.
10 changes: 5 additions & 5 deletions src/app/base/components/ModelDeleteForm/ModelDeleteForm.test.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import ModelDeleteForm from "./ModelDeleteForm";

import { renderWithBrowserRouter, screen, userEvent } from "testing/utils";
import { renderWithBrowserRouter, screen, userEvent } from "@/testing/utils";

it("renders", () => {
renderWithBrowserRouter(
<ModelDeleteForm
initialValues={{}}
modelType="machine"
onSubmit={jest.fn()}
onSubmit={vi.fn()}
submitLabel="Delete"
/>
);
Expand All @@ -18,7 +18,7 @@ it("renders", () => {
});

it("can confirm", async () => {
const onSubmit = jest.fn();
const onSubmit = vi.fn();
renderWithBrowserRouter(
<ModelDeleteForm
initialValues={{}}
Expand All @@ -33,14 +33,14 @@ it("can confirm", async () => {
});

it("can cancel", async () => {
const onCancel = jest.fn();
const onCancel = vi.fn();
renderWithBrowserRouter(
<ModelDeleteForm
cancelLabel="Cancel"
initialValues={{}}
modelType="machine"
onCancel={onCancel}
onSubmit={jest.fn()}
onSubmit={vi.fn()}
/>
);
const cancelBtn = screen.getByRole("button", { name: /cancel/i });
Expand Down
6 changes: 3 additions & 3 deletions src/app/base/components/ModelDeleteForm/ModelDeleteForm.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Col, Row } from "@canonical/react-components";

import type { Props as FormikFormProps } from "app/base/components/FormikForm/FormikForm";
import FormikForm from "app/base/components/FormikForm/FormikForm";
import type { EmptyObject } from "app/base/types";
import type { Props as FormikFormProps } from "@/app/base/components/FormikForm/FormikForm";
import FormikForm from "@/app/base/components/FormikForm/FormikForm";
import type { EmptyObject } from "@/app/base/types";

type Props = {
modelType: string;
Expand Down
12 changes: 6 additions & 6 deletions src/app/base/components/NetworkActionRow/NetworkActionRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ import { ExpandedState } from "../NodeNetworkTab/NodeNetworkTab";
import type {
Selected,
SetSelected,
} from "app/base/components/node/networking/types";
import { useIsAllNetworkingDisabled } from "app/base/hooks";
import { useSidePanel } from "app/base/side-panel-context";
import { DeviceSidePanelViews } from "app/devices/constants";
import { MachineSidePanelViews } from "app/machines/constants";
import type { Node } from "app/store/types/node";
} from "@/app/base/components/node/networking/types";
import { useIsAllNetworkingDisabled } from "@/app/base/hooks";
import { useSidePanel } from "@/app/base/side-panel-context";
import { DeviceSidePanelViews } from "@/app/devices/constants";
import { MachineSidePanelViews } from "@/app/machines/constants";
import type { Node } from "@/app/store/types/node";

type Action = {
disabled: [boolean, string?][];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import { useFormikContext } from "formik";

import type { SSHKeyFormValues } from "../types";

import FormikField from "app/base/components/FormikField";
import TooltipButton from "app/base/components/TooltipButton";
import docsUrls from "app/base/docsUrls";
import FormikField from "@/app/base/components/FormikField";
import TooltipButton from "@/app/base/components/TooltipButton";
import docsUrls from "@/app/base/docsUrls";

export const SSHKeyFormFields = (): JSX.Element => {
const { values } = useFormikContext<SSHKeyFormValues>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { vi } from "vitest";

import BulkActions from "./BulkActions";

import * as sidePanelHooks from "app/base/side-panel-context";
import { MachineSidePanelViews } from "app/machines/constants";
import { DiskTypes, StorageLayout } from "app/store/types/enum";
import * as sidePanelHooks from "@/app/base/side-panel-context";
import { MachineSidePanelViews } from "@/app/machines/constants";
import { DiskTypes, StorageLayout } from "@/app/store/types/enum";
import {
machineDetails as machineDetailsFactory,
machineState as machineStateFactory,
Expand All @@ -20,7 +20,7 @@ import {
renderWithBrowserRouter,
screen,
userEvent,
} from "testing/utils";
} from "@/testing/utils";

describe("BulkActions", () => {
const setSidePanelContent = vi.fn();
Expand Down Expand Up @@ -211,7 +211,7 @@ describe("BulkActions", () => {
renderWithBrowserRouter(
<BulkActions
selected={[selected]}
setBulkAction={jest.fn()}
setBulkAction={vi.fn()}
systemId="abc123"
/>,
{ state }
Expand Down Expand Up @@ -255,7 +255,7 @@ describe("BulkActions", () => {
renderWithBrowserRouter(
<BulkActions
selected={selected}
setBulkAction={jest.fn()}
setBulkAction={vi.fn()}
systemId="abc123"
/>,
{ state }
Expand Down Expand Up @@ -297,7 +297,7 @@ describe("BulkActions", () => {
renderWithBrowserRouter(
<BulkActions
selected={selected}
setBulkAction={jest.fn()}
setBulkAction={vi.fn()}
systemId="abc123"
/>,
{ state }
Expand Down Expand Up @@ -336,7 +336,7 @@ describe("BulkActions", () => {
renderWithBrowserRouter(
<BulkActions
selected={[selected]}
setBulkAction={jest.fn()}
setBulkAction={vi.fn()}
systemId="abc123"
/>,
{ state }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ import { useSelector } from "react-redux";

import { BulkAction } from "../AvailableStorageTable";

import { useSidePanel } from "app/base/side-panel-context";
import { MachineSidePanelViews } from "app/machines/constants";
import machineSelectors from "app/store/machine/selectors";
import type { Machine } from "app/store/machine/types";
import { isMachineDetails } from "app/store/machine/utils";
import type { RootState } from "app/store/root/types";
import type { Disk, Partition } from "app/store/types/node";
import { useSidePanel } from "@/app/base/side-panel-context";
import { MachineSidePanelViews } from "@/app/machines/constants";
import machineSelectors from "@/app/store/machine/selectors";
import type { Machine } from "@/app/store/machine/types";
import { isMachineDetails } from "@/app/store/machine/utils";
import type { RootState } from "@/app/store/root/types";
import type { Disk, Partition } from "@/app/store/types/node";
import {
canCreateOrUpdateDatastore,
canCreateRaid,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ import {
import { useDispatch, useSelector } from "react-redux";
import * as Yup from "yup";

import FormikField from "app/base/components/FormikField";
import FormikForm from "app/base/components/FormikForm";
import { useMachineDetailsForm } from "app/machines/hooks";
import { actions as machineActions } from "app/store/machine";
import machineSelectors from "app/store/machine/selectors";
import type { Machine } from "app/store/machine/types";
import type { MachineEventErrors } from "app/store/machine/types/base";
import { isMachineDetails } from "app/store/machine/utils";
import type { RootState } from "app/store/root/types";
import type { Disk, Partition } from "app/store/types/node";
import FormikField from "@/app/base/components/FormikField";
import FormikForm from "@/app/base/components/FormikForm";
import { useMachineDetailsForm } from "@/app/machines/hooks";
import { actions as machineActions } from "@/app/store/machine";
import machineSelectors from "@/app/store/machine/selectors";
import type { Machine } from "@/app/store/machine/types";
import type { MachineEventErrors } from "@/app/store/machine/types/base";
import { isMachineDetails } from "@/app/store/machine/utils";
import type { RootState } from "@/app/store/root/types";
import type { Disk, Partition } from "@/app/store/types/node";
import {
formatSize,
formatType,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@ import * as Yup from "yup";

import CreateRaidFields from "./CreateRaidFields";

import FormikForm from "app/base/components/FormikForm";
import { useMachineDetailsForm } from "app/machines/hooks";
import { actions as machineActions } from "app/store/machine";
import machineSelectors from "app/store/machine/selectors";
import type { Machine } from "app/store/machine/types";
import type { MachineEventErrors } from "app/store/machine/types/base";
import { isMachineDetails } from "app/store/machine/utils";
import type { RootState } from "app/store/root/types";
import { DiskTypes } from "app/store/types/enum";
import type { Disk, Partition } from "app/store/types/node";
import { isRaid, splitDiskPartitionIds } from "app/store/utils";
import FormikForm from "@/app/base/components/FormikForm";
import { useMachineDetailsForm } from "@/app/machines/hooks";
import { actions as machineActions } from "@/app/store/machine";
import machineSelectors from "@/app/store/machine/selectors";
import type { Machine } from "@/app/store/machine/types";
import type { MachineEventErrors } from "@/app/store/machine/types/base";
import { isMachineDetails } from "@/app/store/machine/utils";
import type { RootState } from "@/app/store/root/types";
import { DiskTypes } from "@/app/store/types/enum";
import type { Disk, Partition } from "@/app/store/types/node";
import { isRaid, splitDiskPartitionIds } from "@/app/store/utils";

export type CreateRaidValues = {
blockDeviceIds: number[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,22 @@ import {
import { useDispatch, useSelector } from "react-redux";
import * as Yup from "yup";

import FormikField from "app/base/components/FormikField";
import FormikForm from "app/base/components/FormikForm";
import { useMachineDetailsForm } from "app/machines/hooks";
import { actions as machineActions } from "app/store/machine";
import machineSelectors from "app/store/machine/selectors";
import type { Machine } from "app/store/machine/types";
import type { MachineEventErrors } from "app/store/machine/types/base";
import { isMachineDetails } from "app/store/machine/utils";
import type { RootState } from "app/store/root/types";
import { DiskTypes } from "app/store/types/enum";
import type { Disk, Partition } from "app/store/types/node";
import { formatSize, formatType, splitDiskPartitionIds } from "app/store/utils";
import FormikField from "@/app/base/components/FormikField";
import FormikForm from "@/app/base/components/FormikForm";
import { useMachineDetailsForm } from "@/app/machines/hooks";
import { actions as machineActions } from "@/app/store/machine";
import machineSelectors from "@/app/store/machine/selectors";
import type { Machine } from "@/app/store/machine/types";
import type { MachineEventErrors } from "@/app/store/machine/types/base";
import { isMachineDetails } from "@/app/store/machine/utils";
import type { RootState } from "@/app/store/root/types";
import { DiskTypes } from "@/app/store/types/enum";
import type { Disk, Partition } from "@/app/store/types/node";
import {
formatSize,
formatType,
splitDiskPartitionIds,
} from "@/app/store/utils";

type CreateVolumeGroupValues = {
name: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ import * as Yup from "yup";

import UpdateDatastoreFields from "./UpdateDatastoreFields";

import FormikForm from "app/base/components/FormikForm";
import { useMachineDetailsForm } from "app/machines/hooks";
import { actions as machineActions } from "app/store/machine";
import machineSelectors from "app/store/machine/selectors";
import type { Machine } from "app/store/machine/types";
import type { MachineEventErrors } from "app/store/machine/types/base";
import { isMachineDetails } from "app/store/machine/utils";
import type { RootState } from "app/store/root/types";
import type { Disk, Partition } from "app/store/types/node";
import { isDatastore, splitDiskPartitionIds } from "app/store/utils";
import FormikForm from "@/app/base/components/FormikForm";
import { useMachineDetailsForm } from "@/app/machines/hooks";
import { actions as machineActions } from "@/app/store/machine";
import machineSelectors from "@/app/store/machine/selectors";
import type { Machine } from "@/app/store/machine/types";
import type { MachineEventErrors } from "@/app/store/machine/types/base";
import { isMachineDetails } from "@/app/store/machine/utils";
import type { RootState } from "@/app/store/root/types";
import type { Disk, Partition } from "@/app/store/types/node";
import { isDatastore, splitDiskPartitionIds } from "@/app/store/utils";

export type UpdateDatastoreValues = {
datastore: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import { Col, Row, Select } from "@canonical/react-components";
import { useDispatch } from "react-redux";
import * as Yup from "yup";

import FormikField from "app/base/components/FormikField";
import FormikForm from "app/base/components/FormikForm";
import { useMachineDetailsForm } from "app/machines/hooks";
import { actions as machineActions } from "app/store/machine";
import type { MachineDetails } from "app/store/machine/types";
import type { MachineEventErrors } from "app/store/machine/types/base";
import { usesStorage } from "app/store/utils";
import FormikField from "@/app/base/components/FormikField";
import FormikForm from "@/app/base/components/FormikForm";
import { useMachineDetailsForm } from "@/app/machines/hooks";
import { actions as machineActions } from "@/app/store/machine";
import type { MachineDetails } from "@/app/store/machine/types";
import type { MachineEventErrors } from "@/app/store/machine/types/base";
import { usesStorage } from "@/app/store/utils";

const AddSpecialFilesystemSchema = Yup.object().shape({
fstype: Yup.string().required(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ import { Button, MainTable, Tooltip } from "@canonical/react-components";
import type { MainTableRow } from "@canonical/react-components/dist/components/MainTable/MainTable";
import { useDispatch } from "react-redux";

import TableActionsDropdown from "app/base/components/TableActionsDropdown";
import ActionConfirm from "app/base/components/node/ActionConfirm";
import { useSidePanel } from "app/base/side-panel-context";
import { MachineSidePanelViews } from "app/machines/constants";
import type { ControllerDetails } from "app/store/controller/types";
import { actions as machineActions } from "app/store/machine";
import type { MachineDetails } from "app/store/machine/types";
import type { Filesystem, Disk, Partition } from "app/store/types/node";
import TableActionsDropdown from "@/app/base/components/TableActionsDropdown";
import ActionConfirm from "@/app/base/components/node/ActionConfirm";
import { useSidePanel } from "@/app/base/side-panel-context";
import { MachineSidePanelViews } from "@/app/machines/constants";
import type { ControllerDetails } from "@/app/store/controller/types";
import { actions as machineActions } from "@/app/store/machine";
import type { MachineDetails } from "@/app/store/machine/types";
import type { Filesystem, Disk, Partition } from "@/app/store/types/node";
import {
formatSize,
isMounted,
Expand Down
14 changes: 7 additions & 7 deletions src/app/base/side-panel-context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ import {
import {
DomainListSidePanelViews,
type DomainListSidePanelContent,
} from "app/domains/views/DomainsList/constants";
import { ImageSidePanelViews } from "app/images/constants";
import type { ImageSidePanelContent } from "app/images/types";
import { KVMSidePanelViews } from "app/kvm/constants";
import type { KVMSidePanelContent } from "app/kvm/types";
import { MachineSidePanelViews } from "app/machines/constants";
import type { MachineSidePanelContent } from "app/machines/types";
} from "@/app/domains/views/DomainsList/constants";
import { ImageSidePanelViews } from "@/app/images/constants";
import type { ImageSidePanelContent } from "@/app/images/types";
import { KVMSidePanelViews } from "@/app/kvm/constants";
import type { KVMSidePanelContent } from "@/app/kvm/types";
import { MachineSidePanelViews } from "@/app/machines/constants";
import type { MachineSidePanelContent } from "@/app/machines/types";
import {
NetworkDiscoverySidePanelViews,
type NetworkDiscoverySidePanelContent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ import configureStore from "redux-mock-store";

import DeviceNetworkForms from "./DeviceNetworkForms";

import { DeviceSidePanelViews } from "app/devices/constants";
import type { DeviceSidePanelContent } from "app/devices/types";
import type { RootState } from "app/store/root/types";
import { DeviceSidePanelViews } from "@/app/devices/constants";
import type { DeviceSidePanelContent } from "@/app/devices/types";
import type { RootState } from "@/app/store/root/types";
import {
deviceDetails as deviceDetailsFactory,
deviceState as deviceStateFactory,
rootState as rootStateFactory,
} from "testing/factories";
import { renderWithBrowserRouter, screen } from "testing/utils";
} from "@/testing/factories";
import { renderWithBrowserRouter, screen } from "@/testing/utils";

const mockStore = configureStore<RootState>();
let state: RootState;
Expand All @@ -30,7 +30,7 @@ it("renders a form when appropriate sidepanel view is provided", () => {
};
renderWithBrowserRouter(
<DeviceNetworkForms
setSidePanelContent={jest.fn()}
setSidePanelContent={vi.fn()}
sidePanelContent={sidePanelContent}
systemId="abc123"
/>,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { useCallback } from "react";

import type { SidePanelContentTypes } from "app/base/side-panel-context";
import { DeviceSidePanelViews } from "app/devices/constants";
import AddInterface from "app/devices/views/DeviceDetails/DeviceNetwork/AddInterface";
import RemoveInterface from "app/devices/views/DeviceDetails/DeviceNetwork/DeviceNetworkTable/RemoveInterface";
import EditInterface from "app/devices/views/DeviceDetails/DeviceNetwork/EditInterface";
import type { Device } from "app/store/device/types";
import type { SidePanelContentTypes } from "@/app/base/side-panel-context";
import { DeviceSidePanelViews } from "@/app/devices/constants";
import AddInterface from "@/app/devices/views/DeviceDetails/DeviceNetwork/AddInterface";
import RemoveInterface from "@/app/devices/views/DeviceDetails/DeviceNetwork/DeviceNetworkTable/RemoveInterface";
import EditInterface from "@/app/devices/views/DeviceDetails/DeviceNetwork/EditInterface";
import type { Device } from "@/app/store/device/types";

type Props = SidePanelContentTypes & {
systemId: Device["system_id"];
Expand Down
Loading

0 comments on commit c7c81de

Please sign in to comment.