-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): use uv for freeze-requirements #1779
base: main
Are you sure you want to change the base?
Conversation
d9b8bae
to
5af55fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about updating the HACKING guide to advise installing uv
?
5af55fe
to
e626698
Compare
@mr-cal good idea. We don't have a HACKING file but I did the next best thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 UV 😎
CONTRIBUTING.md
Outdated
It's recommended to use `uv` for setting up your development environment, but | ||
this is not required. `uv` is available [as a snap](https://snapcraft.io/astral-uv) | ||
and from [official sources](https://docs.astral.sh/uv/getting-started/installation/). | ||
If using `uv`, substitute `virtualenv` with `uv venv` and `pip` with `uv pip`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if uv
is recommended, these instructions should be along the lines of if not using ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to just not explain how to use something else anyway :-)
This speeds up the
freeze-requirements.sh
script quite substantially while still having equivalent output.