Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): use uv for freeze-requirements #1779

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Aug 1, 2024

This speeds up the freeze-requirements.sh script quite substantially while still having equivalent output.

@lengau lengau marked this pull request as ready for review August 23, 2024 22:04
@lengau lengau requested a review from tigarmo August 23, 2024 22:04
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about updating the HACKING guide to advise installing uv?

@lengau
Copy link
Collaborator Author

lengau commented Aug 28, 2024

@mr-cal good idea. We don't have a HACKING file but I did the next best thing.

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 UV 😎

CONTRIBUTING.md Outdated
It's recommended to use `uv` for setting up your development environment, but
this is not required. `uv` is available [as a snap](https://snapcraft.io/astral-uv)
and from [official sources](https://docs.astral.sh/uv/getting-started/installation/).
If using `uv`, substitute `virtualenv` with `uv venv` and `pip` with `uv pip`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if uv is recommended, these instructions should be along the lines of if not using ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to just not explain how to use something else anyway :-)

CONTRIBUTING.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants