Add tox configuration to the repository #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a tox.ini file for running a variety of code quality tests including linting, formatting using black, and running/passing unit tests. This also includes a refactor of the unit tests to move them into a tests/unit directory for future addition of additional testing such as integration testing, functional testing, etc. The run_tests script is dropped in favor of using the tox tool set. Signed-off-by: Billy Olsen <billy.olsen@canonical.com>
The disable_i40e_lldp function should not issue a system exit call when no nics are found, instead it should simply return from the function. Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
Add github ci workflow to run lint, static analysis and unit tests on each pull request. Signed-off-by: Billy Olsen <billy.olsen@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the tox configuration to the repository to run unit tests, linting, etc and ensure consistency.
This branch additionally contains a bug fix for the recently merged i40e stuff.