Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW:Week-2 types_&sequences_ #150

Merged
merged 5 commits into from
Oct 16, 2023
Merged

HW:Week-2 types_&sequences_ #150

merged 5 commits into from
Oct 16, 2023

Conversation

CanberkAkar
Copy link
Contributor

No description provided.

Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the function must be remove_duplicates, not remove_dublicates.

Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix this.

@@ -0,0 +1,33 @@
my_list = ["a","b","c","d","e"]
my_tuple = {"canberk","akar",25}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a tuple

Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverse_dict could not pass the tests.

def reverse_dict(dictionary):
reversed_dict = {}
for key, value in dictionary.items():
if value not in reversed_dict:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this if line ruins the function, it is not passing the tests.

Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is ok.

@canbula canbula merged commit 1e2ea17 into canbula:master Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants