umutcan homework02 types and sequences #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canbula
requested changes
Oct 16, 2023
canbula
requested changes
Oct 16, 2023
canbula
requested changes
Oct 17, 2023
Week02/sequences_umutcan_turk.py
Outdated
| "headset":120 | ||
| } | ||
|
|
||
| def remove_duplicates(list): |
There was a problem hiding this comment.
Here you get the wrong parameter
Week02/sequences_umutcan_turk.py
Outdated
|
|
||
| def remove_duplicates(list): | ||
| new_list = [] | ||
| for key in my_list: |
There was a problem hiding this comment.
Therefore here you check the wrong sequence
canbula
requested changes
Oct 17, 2023
Week02/sequences_umutcan_turk.py
Outdated
| "headset":120 | ||
| } | ||
|
|
||
| def remove_duplicates(listParam): |
There was a problem hiding this comment.
This is ok but I need you to follow the conventions about variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist
-[ X] I have performed a self-review of my own code
-[ X] I have run the code locally and it works as expected
Screenshots (if appropriate)