Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple file extensions in S3 #122

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Support multiple file extensions in S3 #122

merged 4 commits into from
Feb 17, 2021

Conversation

Moglum
Copy link
Contributor

@Moglum Moglum commented Nov 11, 2020

Add support for multiple state file extensions in S3

I changed AWS_FILE_EXTENSION to be []string (or comma-separated list via ENV variable) of extensions, ie .tfstate,.state. It's backward compatible and the default value remains the same.

config/config.go Outdated Show resolved Hide resolved
db/db.go Outdated Show resolved Hide resolved
state/aws.go Outdated Show resolved Hide resolved
@Moglum
Copy link
Contributor Author

Moglum commented Feb 12, 2021

Updated to []string and added env-delim="," tag.

@Moglum
Copy link
Contributor Author

Moglum commented Feb 12, 2021

@raphink hopefully addressed all your feedback. Will open another PR for the unrelated change.

@Moglum Moglum changed the title Support multiple file extensions in S3 + fix for nil pointer error Support multiple file extensions in S3 Feb 12, 2021
@Moglum Moglum requested a review from raphink February 12, 2021 21:58
@raphink raphink merged commit c93f679 into camptocamp:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants